WSA Winner
Tuesday November 9th, 2004
It's a site featuring stuff about Mr. T. It validates, has CSS and other web-standards stuff...
Oh bloody hell, it has Mr. T on every page too, OK?
There's some stuff in the code that isn't how I would choose to do it and I could get grumpy about <div>s called 'frontEntryTextMiddle', but the site made me smile and Mike Essl and Greg Rivera have done a great job. Oh, did I mention that site has Mr. T on it? Cue theme music... ;)
Reviewed by Andy Clarke
#1
Andy, you missed a perfect opportunity to land a "I pity the fool who don't validate as XHTML 1.0 Strict!"
Posted by Shaun Inman :: November 9th, 2004 at 10:22 PM
#2
Hey Andy, Mike here, the guy that made the T site.
What is your beef with "frontEntryTextMiddle" I thought having class names that are descriptive of the content are good form? I am just curious as to how you would do it. For instance this site has an id named BigImage and Topshadow is that really any different?
My bigger problem with my code is the number of divs. I coded it from scratch 4 times and am still trying to get it to be a bit leaner.
Any insight as to what you might think is better would be much appreciated.
Posted by Essl :: November 10th, 2004 at 01:04 AM
#3
Finally a dream comes true: my favourite character presented in Web Standards. Helluva nice! Congrats to the fools, ehr I mean the authors. :3
Posted by Neko :: November 10th, 2004 at 11:52 AM
#4
Essl:
I think the beef is that it's descriptive of it's display, where it is on the page, rather then what the subject/content is.
IE: "productdescription"
Another example would be creating blue text as a highlighting feature and calling the class "blue-txt" where, "highlight" would suffice. Is it gonna be blue text forever?
Are the product descriptions always going to be displaying in the middle? Maybe, maybe not, but one thing is sure. They will always be "productdescriptions".
Come again, maybe it's just the length. If that's the case, meh. To each their own.
Posted by Ryan :: November 10th, 2004 at 02:49 PM
#5
Ryan,
I totally agree with you. That is probably the beef. I had not even though of that. I used it as a device to remember what code did what, but I agree that any position information should probably be left out. I mostly asked because I really dislike it when reviewers make comments like that with out offering up the "how and the why." But I should say I am honored to be included here.
Posted by Essl :: November 10th, 2004 at 03:13 PM
#6
Hi Mike,
I wrote a while back on my own site about naming conventions and abandoning 'presentational' naming in favour of naming divs and classes based on content rather than positioning or styling (www.stuffandnonsense.co.uk/archives/whats_in_a_name_pt2.html).
Ryan hit the nail on the head, but I must say that this is only a minor, rather puritan gripe in what is an outstanding site. That is why I chose to award it here.
Posted by Andy Clarke :: November 10th, 2004 at 03:44 PM
Comments on: Mr. T and Me